Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom stats collecting intervals #168

Merged
merged 6 commits into from
Jan 5, 2021
Merged

Custom stats collecting intervals #168

merged 6 commits into from
Jan 5, 2021

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Jan 4, 2021 •
edited
Loading

Enable customizing stats collecting intervals using ENV variables

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Enable customizing stats collecting intervals using ENV variables
  • Update README file

Issues

Closes #167

@MakMuftic MakMuftic changed the title Mmuftic/fix data collection interval Custom stats collecting intervals Jan 4, 2021
@MakMuftic MakMuftic marked this pull request as ready for review January 4, 2021 18:31
mpetrunic
mpetrunic approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna merge this for now but why can't we store total node earnings to db and update it on every payout. So on each call to metrics, we would fetch from db and display latest value for each node?

@mpetrunic mpetrunic merged commit 4b15d92 into master Jan 5, 2021
@mpetrunic mpetrunic deleted the mmuftic/fix-data-collection-interval branch January 5, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakMuftic @mpetrunic