Update for deps #79
Update for deps #79
Conversation
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 90.22% 90.31% +0.08%
==========================================
Files 9 9
Lines 696 702 +6
==========================================
+ Hits 628 634 +6
Misses 68 68
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Project.toml
Outdated
| CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b" | ||
| CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597" | ||
| CompilerSupportLibraries_jll = "e66e0078-7015-5450-92f7-15fbd957f2ae" | ||
| Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | ||
| FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b" | ||
| ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210" | ||
| JLLWrappers = "692b3bcd-3c85-4b1f-b108-f13ce0eb3210" | ||
| LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | ||
| MLJBase = "a7f614a8-145f-11e9-1d2a-a57a1082229d" | ||
| MLJModelInterface = "e80e1ace-859a-464e-9ed9-23947d8ae3ea" | ||
| Optim = "429524aa-4258-5aef-a3af-852621145aeb" | ||
| Parameters = "d96e819e-fc66-5662-9728-84c9c7592b0a" | ||
| Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7" | ||
| RDatasets = "ce6b1742-4840-55fa-b093-852dadbb1d8b" |
There was a problem hiding this comment.
I'm confused, why is this adding dependencies which are unused?
There was a problem hiding this comment.
Good catch, I had updated my environment while updating the tests. Going to try to get the docs working properly again and will clean that up before merging.
| FillArrays = "0.9, 0.10, 0.11" | ||
| ForwardDiff = "0.10" | ||
| MLJBase = "0.15, 0.16" | ||
| MLJModelInterface = "0.3" | ||
| JLLWrappers = "1" |
There was a problem hiding this comment.
This must be the first time I see a compat with JLLWrappers outside of a JLL package.
There was a problem hiding this comment.
CompatHelper gets mad at me if I don't I guess. Guess it should work the same as any other package but probably not vital.
Implemented responsename and updated dof to match current definition. Moved the codemeta to a cff format.
Closes #70 #71 #72 #73 #74 #75 #76
Basically, a PR to update a few things which have gathered some dust.
responsename, updateddofdefinition, and docs (module is now StatsAPI)I tried updating the
show(io, mime, obj)instead of using the 2-args method but didn't work well so that is out of scope for this one.