Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update NuGet to use Newtonsoft.Json 11.0.1 (#3347)" #3383

Merged
merged 1 commit into from
May 6, 2020
Merged

Revert "Update NuGet to use Newtonsoft.Json 11.0.1 (#3347)" #3383

merged 1 commit into from
May 6, 2020

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented May 6, 2020

This reverts commit 5f04e58.

Bug

Fixes: NuGet/Home#9540
Regression: Yes

Fix

Details: revert back to Newtonsoft.Json 9.0.1

Testing/Validation

Tests Added: No
Reason for not adding tests: just a dependency version change
Validation:

kartheekp-ms
kartheekp-ms approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@kartheekp-ms kartheekp-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can start the insertion process once the CI has completed successfully.

@nkolev92 nkolev92 merged commit 12a375a into dev May 6, 2020
@nkolev92 nkolev92 deleted the dev-zivkan-revert-newtonsoft-json-9 branch May 6, 2020 21:44
@nkolev92
Copy link
Member

nkolev92 commented May 6, 2020

Force merging to work around CI issues.
This is important enough for insertion to bypass the checks

@nkolev92 nkolev92 mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartheekp-ms kartheekp-ms kartheekp-ms approved these changes

@aortiz-msft aortiz-msft Awaiting requested review from aortiz-msft

@cristinamanum cristinamanum Awaiting requested review from cristinamanum

@dominoFire dominoFire Awaiting requested review from dominoFire

@donnie-msft donnie-msft Awaiting requested review from donnie-msft

@dtivel dtivel Awaiting requested review from dtivel

@heng-liu heng-liu Awaiting requested review from heng-liu

@nkolev92 nkolev92 Awaiting requested review from nkolev92

@rrelyea rrelyea Awaiting requested review from rrelyea

@zkat zkat Awaiting requested review from zkat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert Newtonsoft.Json to 9.0.1
3 participants
@zivkan @nkolev92 @kartheekp-ms