add missing test coverage for AbandonedMutexException in NuGet migrations logic #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominoFire
previously approved these changes
Dec 12, 2022
erdembayar
reviewed
Dec 12, 2022
erdembayar
reviewed
Dec 12, 2022
kartheekp-ms
force-pushed
the
dev-kpms-test-abandonedmutex-error
branch
2 times, most recently
from
a7417a4
to
bb27126
Compare
kartheekp-ms
force-pushed
the
dev-kpms-test-abandonedmutex-error
branch
from
bb27126
to
170c754
Compare
dominoFire
approved these changes
Dec 14, 2022
erdembayar
approved these changes
Dec 14, 2022
kartheekp-ms
added a commit
that referenced
this pull request
Jan 5, 2023
kartheekp-ms
added a commit
that referenced
this pull request
Jan 5, 2023
kartheekp-ms
added a commit
that referenced
this pull request
Jan 5, 2023
kartheekp-ms
added a commit
that referenced
this pull request
Jan 5, 2023
kartheekp-ms
added a commit
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Tracking: NuGet/Home#12159
Regression? Last working version:
Description
I noticed that test coverage is missing for a scenario when I addressed the linked (tracking) issue in 41c08c5 and 3f3f9ec commits. Basically, the scenario is, whenever a thread is abandoned because of the application has been terminated abruptly (for example, by using Windows Task Manager) then the next migration run executes successfully. No product changes are introduced in this PR.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation