Add support for markdown > alerts via markdig #10173
Conversation
|
I guess as a test PR, it showcases that for someone that can actually run the site, it should be fairly straightforward to add support for this :) |
Thank you for your contribution. I could help to test it. |
Thanks, Lynn. Please add screenshot here. |
|
@lyndaidaii |
src/NuGetGallery/Content/Site.css
Outdated
| @@ -1374,20 +1374,20 @@ ul.accordion { | |||
| } | |||
|
|
|||
| ul.accordion li.accordion-item .accordion-expand-link { | |||
| background: none!important; | |||
| background: none !important; | |||
There was a problem hiding this comment.
Also this change should have been done in .less file rather than this file?
There was a problem hiding this comment.
I have no idea where things are in your code base. Feel free to close this issue which was mostly a demonstration that fixing the issue is mostly adding one line of code and whichever styles you want for the site 🙏
There was a problem hiding this comment.
would you mind pointing at which .less file you're referring to?
There was a problem hiding this comment.
@NuGet/gallery-team
Do you know which less file we need to make changes to? I never change any of them.
|
Test should be passing now. Screenshots below. Dark mode:
Light mode;
|
Markdig supports alert blocks as documented at https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/AlertBlockSpecs.md. Bumping markdig and adding `.UseAlertBlocks()` now renders the expected html. Fixes NuGet#10125
If we don't unset it, the default bootstrap p style turns dark mode illegible (uses white-ish color). This seems to be an issue specific to the very old version of Bootstrap being used (v3.x). When running the site locally, I could not find any other .css (or .less) files being built or linked from the page, so I placed the only needed style in the only other style file other than bootstrap.
|
any updates @erdembayar @lyndaidaii ? |
Sorry, we'll review this week or at the latest next week. We have other priorities at the moment and need some time. |
I had trouble in building gallery in local since we merged a couple of repos into one. My .NET version on dev is out of date now. Haven't checked in since then. If you could build gallery in local fine, could you help take a look at UI? |
Partial fix for #10125
Markdig supports alert blocks as documented at https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/AlertBlockSpecs.md.
Bumping markdig and adding
.UseAlertBlocks()now renders the expected html.Not sure how to go about adding the styles as needed.