Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how we indicate the relationship between a core class and its matching OBO one #23

Open
beckyjackson opened this issue Jul 11, 2019 · 5 comments

Comments

@beckyjackson
Copy link
Collaborator

beckyjackson commented Jul 11, 2019

From @cmungall

Currently we have been making notes as rdfs:comments but we should do this in a better way

If we believe they are truly equivalent then equivalentClasses is appropriate - however, this is a pain to work with in protege (since you induce a class declaration). I would vote for editing as a skos:exactMatch (we can avoid declaring a class). It could be converted to equivalence during release

For close matches, skos:closeMatch, otherwise rdfs:seeAlso?

Or we could make our own vocabulary for this?

@beckyjackson
Copy link
Collaborator Author

Currently, there is a mix of skos:exactMatch and skos:closeMatch in core to link to external terms. See beckyjackson#6

We will use skos:exactMatch for any external terms that are equivalent terms so that we can later add the equivalence axioms.

@beckyjackson
Copy link
Collaborator Author

@cmungall Looking at the matches in the current core-edit.owl file, I see:

Core Term Exact Match Exact Match Label
organism MeSH:D009938 Organizations
organism biotop:Organ Organ
organism CCO:Organization Organization
organism SIO:000012 organization
organization OBI:0100026 organism

I think these are incorrect and should be removed. Maybe Organ can be moved as a skos:closeMatch for 'gross anatomical part'...

Additionally, 'cell' has exactMatch http://purl.obolibrary.org/obo/CL_0000000 - should this be skos:closeMatch instead? The GO cell IRI is not included in the matches, perhaps this should be a close match as well?

@cmungall
Copy link
Contributor

I can redo without the stemming to avoid the junk.

Let's discuss how best to manage this moving forward next week

@bpeters42
Copy link
Contributor

bpeters42 commented Jul 25, 2019 via email

@cmungall
Copy link
Contributor

Restating some of what was in the archived repo: beckyjackson#6

There are at least three distinct use cases here, highest priority first:

  1. We want to be able to state (using logical axioms if possible) the relationship between a CORE class and an OBO class. Ideally these will eventually be equivalent based on discussions between particular OBO ontologies and core, but in the meantime there will be some that will not be equivalent, so we want to know the logical relationship, reason about implications, etc
  2. Similarly, we would like to know the relationship between CORE classes and non-OBO upper ontology classes, e.g biotop, SIO, wikidata, and also schemas like biolink. While this may be lower priority, I would argue this is easy to do, highly informative (we are not the first to make an upper bio ontology) and also potentially useful for buy-in from a larger community
  3. We would like to know where we have terminological clashes, where we use a label where another community uses it differently. I strongly think we should avoid the trap many philosophical OBOs fall into of choosing a label which has one meaning for a community, and then applying it to a class that has a more restricted or different meaning.

For 1, these should obviously be manually curated. Becky has done a first pass in #28, and she lists some outstanding questions in that PR

For 2, I am happy to take on this. These should also be manually curated, and will go in a separate file. Not clear if logical axioms or skos is the most appropriate here.

For 3, this was merged in beckyjackson#6. This is automatic since the whole point is to see where we have clashes. skos is an appropriate vocabulary for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants