[16.0][FIX] document_page_tag: Use api.model_create_multi #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
64a8591
to
4f09857
Compare
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
2 times, most recently
from
d83332f
to
6abb713
Compare
aleuffre
suggested changes
Jul 29, 2024
Comment on lines
18
to
27
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| """Be nice when trying to create duplicates""" | ||
| existing = self.search([("name", "=ilike", vals["name"])], limit=1) | ||
| if existing: | ||
| return existing | ||
| return super().create(vals) | ||
| for vals in vals_list: | ||
| existing = self.search([("name", "=ilike", vals["name"])], limit=1) | ||
| if existing: | ||
| return existing | ||
| return super().create(vals_list) |
There was a problem hiding this comment.
Issue: When trying to create two tags at the same time, one that exists and one that doesn't, we return the one tag that does exist and don't create the one that doesn't.
There was a problem hiding this comment.
Changes included to handle tag creation with one exist and not exist at the same time
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
6abb713
to
e6c793d
Compare
PicchiSeba
reviewed
Aug 5, 2024
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
e6c793d
to
8a82c39
Compare
|
watch out for the pre-commit error at line 68 in |
Using decorator api.model_create_multi for create method in document_page_tag model
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
8a82c39
to
9d749c8
Compare
aleuffre
approved these changes
Aug 23, 2024
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using decorator api.model_create_multi for create method in document_page_tag model in order to avoid below warning:
WARNING devel odoo.api.create: The model odoo.addons.document_page_tag.models.document_page_tag is not overriding the create method in batch