[FIX] ocabot migration duplicating lines in migration issue? #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 15, 2022
| @@ -39,7 +39,7 @@ def _set_lines_issue(gh_pr_user_login, gh_pr_number, issue_body, module): | |||
| if added: # Bypass the checks for faster completion | |||
| lines.append(line) | |||
| continue | |||
| groups = re.match(rf"^- \[( |x)\] {module}( |\r)", line) | |||
| groups = re.match(rf"^- \[( |x)\] {module}", line) | |||
There was a problem hiding this comment.
This is not correct at all, as it can match with partial module names. Why is it incorrect? Maybe we can match the end of the line instead.
There was a problem hiding this comment.
Thanks for the review!
I haven't managed to reproduce exactly the issue #214 because I don't know how the Migration issue is created, but I think this regex might be the cause.
I have found that \b is made exactly for matching full words, see https://docs.python.org/3/library/re.html#regular-expression-syntax, can you check if it looks better now?
A new line was created because the regex was expecting something after the module name
SirTakobi
force-pushed
the
fix-issue214
branch
from
a721476
to
44ad4a5
Compare
pedrobaeza
approved these changes
Oct 17, 2022
|
@sbidoul can you merge and deploy, please? |
|
Thank you @SirTakobi. I just deployed. |
|
Let's see if we finally end with this problem. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #214