Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] Add module partner_tz #876

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Conversation

grindtildeath
Copy link
Contributor

This module removes timezone default value on res.partner and display the field
on form view.

@grindtildeath grindtildeath changed the title Add module partner_tz [13.0] Add module partner_tz Apr 2, 2020
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell

setup/partner_tz/odoo/addons/partner_tz Show resolved Hide resolved
partner_tz/tools/tz_utils.py Show resolved Hide resolved
partner_tz/__manifest__.py Show resolved Hide resolved
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you check travis error?

@LoisRForgeFlow
Copy link
Contributor

@grindtildeath Hi, this module is a dependency for several modules you are proposing, if we get this merged it will ease testing and attract reviewers. Can you take a few minutes to fix travis and push this forward? 🚀

Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the module to adding the timezone to the partner form.

But you might think about the suggested functionality of setting the default partner timezone based on the partners country...

@@ -0,0 +1,58 @@
# Copyright 2020 Camptocamp SA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions presented here are very thin wrappers around the original functions from pytz. I think this is of questionable value. Better use the original pytz functions that are generally available and not depending on having this particular module installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your review @NL66278
The value of a function is quite subjective in any case, but to me they make tz conversions more explicit and avoid repeats. Moreover they are only tools that won't change anything when someone installs this module.
So I'm sorry but I don't see why having this file here, and using it in other modules having this module as a dependency would be a problem...

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@rousseldenis
Copy link
Sponsor Contributor

@grindtildeath I'd prefer explicit words in module name, partner_timezone is better

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Apart module name

@rousseldenis
Copy link
Sponsor Contributor

And some tests for conversion functions should be great

@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@jgrandguillaume
Copy link
Member

Merging as Alpha version is set. Thank everyone for the review.

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-876-by-jgrandguillaume-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 265ccff into OCA:13.0 Sep 29, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 89850e4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants