Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] pos_bypass_global_discount #1220

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] pos_bypass_global_discount #1220

wants to merge 1 commit into from
+657 −0

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Jul 10, 2024 •
edited
Loading

Note

  • This module is meant to be installed as a companion to sale_global_discount. It makes sure the POS will also honors the bypass_global_discount field when user inputs a Discount at the Order level.

@cyrilmanuel
Copy link

adding description on the PR :

This module is meant to be installed as a companion to sale_global_discount. It makes sure the POS will also honors the bypass_global_discount field when user inputs a Discount at the Order level.

@trisdoan trisdoan force-pushed the 16.0-add-pos_bypass_global_discount branch from 9b919a5 to 6d09939 Compare July 16, 2024 02:14
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1220-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 18, 2024
@OCA-git-bot
Merge PR #1220 into 16.0
e4ac35d 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1220-by-ivantodorovich-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk simahawk mentioned this pull request Sep 19, 2024
Open
@trisdoan trisdoan force-pushed the 16.0-add-pos_bypass_global_discount branch from 6d09939 to 245c3d5 Compare September 19, 2024 07:21
@simahawk
Copy link

#1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@Ricardoalso Ricardoalso Ricardoalso approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trisdoan @cyrilmanuel @OCA-git-bot @ivantodorovich @simahawk @Ricardoalso