[13.0][ADD] base_time_window

[grindtildeath]

This module provides base classes and models to manage time windows through
time.window.mixin.

Example implementation for the mixin can be found in module test_base_time_window.

As a time window will always be linked to a related model thourgh a M2o relation,
when defining the new model inheriting the mixin, one should pay attention to the
following points in order to have the overlapping check work properly:

• Define class property _overlap_check_field: This must state the M2o field to
  use for the to check of overlapping time window records linked to a specific
  record of the related model.

• Add the M2o field to the related model in the api.constrains:

For example:

.. code-block:: python
class PartnerTimeWindow(models.Model):
_name = 'partner.time.window'
_inherit = 'time.window.mixin'
partner_id = fields.Many2one(
res.partner', required=True, index=True, ondelete='cascade'
)
_overlap_check_field = 'partner_id'
@api.constrains('partner_id')
def check_window_no_overlaps(self):
return super().check_window_no_overlaps()

[lmignon]

IMO, to be complete, we should add a demo module with the appropriate unittest. I prefer to keep the tests related to the logic implemented into this new addon into the same repository and without dependencies on other addon.

[grindtildeath]

@lmignon I added a test_base_time_window module in the last commits, with your test suite and an extra one related to the usage I introduced with mixin.

[lmignon]

Great. Thank you @grindtildeath for your refactoring and generalization of this transversal concept. (Code review)

[jgrandguillaume]

LGTM

[simahawk]

I'd split this to _get_time_window_sql which returns (sql, sql_params)

[simahawk]

this field and the method IMO could stay in another mixin time.window.consumer.mixin

[jgrandguillaume]

/ocabot merge

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1798-by-jgrandguillaume-bump-no, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 19f7342. Thanks a lot for contributing to OCA. ❤️