[13.0][MIG] stock_storage_type_putaway_strategy #13
Conversation
| ) | ||
|
|
||
| def _get_pack_putaway_strategy(self, putaway_location, quant, product): | ||
| package_storage_type = False |
There was a problem hiding this comment.
can you just add a docsting to show on the method description all return case possibly ?
| return not (max_weight and pack_weight and pack_weight > max_weight) | ||
|
|
||
| def _existing_quants(self, products=None, lot=None): | ||
|
|
| "max_weight", | ||
| ) | ||
| def _compute_has_restrictions(self): | ||
| for slst in self: |
There was a problem hiding this comment.
are we sure they is default values for this compute ?
There was a problem hiding this comment.
What do you mean here? has_restrictions is always computed in the function since the result of any is used...
| class TestStorageTypeMove(TestStorageTypeCommon): | ||
|
|
||
| def test_package_level_location_dest_domain(self): | ||
| pass |
There was a problem hiding this comment.
you don't have time to do this tests or they are not commited ?
| # allowing the package into the location | ||
| allowed = True | ||
| break | ||
| if not allowed: |
There was a problem hiding this comment.
@grindtildeath I think here we should display different messages according to why it breaks. Having always the same error message is very confusing. In my case it happens trying to post an inventory with several quants in a bin with "only_empty" and I didn't understand what was wrong for a while.
| def _get_pack_putaway_strategy(self, putaway_location, quant, product): | ||
| package_storage_type = False | ||
| if quant: | ||
| package_storage_type = quant.package_id.package_storage_type_id |
There was a problem hiding this comment.
if package_storage_type_id exists on package_id take it, otherwise look at the one stored on the quant
…e_type_putaway_strategy Add support of lines without packages in roadmap
|
Merged into #12 |
Shopfloor scan anything + fix docs for non-process endpoints
Depends on: