-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restrict fileGrp names more #746
Comments
Agreed. We should probably also make this explicit in the spec, since we do not require the naming schema ( |
Indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Although the spec requires
fileGrp/@USE
names to follow a very strict scheme, we have not enforced this in core (only the workspace validator checks it). However, if fileGrp names are left completely unrestricted, we get follow-up problems: For example, since we normally base file IDs on fileGrp names, some user choices will unwittingly end up in invalid METS:I therefore suggest extending
add_file
'score/ocrd_models/ocrd_models/ocrd_mets.py
Lines 298 to 299 in d9f660e
add_file_grp
.The text was updated successfully, but these errors were encountered: