Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure --mets is properly set in bashlib #927

Open
kba opened this issue Oct 21, 2022 · 1 comment
Open

Ensure --mets is properly set in bashlib #927

kba opened this issue Oct 21, 2022 · 1 comment

Comments

@kba
Copy link
Member

kba commented Oct 21, 2022

We should probably also add some basename tests with the dummy processor (like test_mets_basename and test_ocrd_dummy.TestDummyProcessor combined).

Also, we have next to no tests for bashlib processing yet.

BTW, before ocrd-olena-binarize (and the rest of them) can actually handle the non-default basename case correctly, we would still have to rewrite all the ocrd workspace calls to something like ocrd workspace -m $(basename ${ocrd__argv[mets_file]}).

And so to facilitate that, in turn, we should probably add something like ocrd__workspace function to lib.bash (which would work both before and after the usual cd call)...

Originally posted by @bertsky in #925 (review)

@bertsky
Copy link
Collaborator

bertsky commented Nov 10, 2022

This ocrd__workspace could also do what is needed for #938 – i.e. downloading locally (without changing the href).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants