Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

does not work with nondefault METS basename #40

Closed
bertsky opened this issue May 18, 2022 · 2 comments · Fixed by #41
Closed

does not work with nondefault METS basename #40

bertsky opened this issue May 18, 2022 · 2 comments · Fixed by #41

Comments

@bertsky
Copy link
Collaborator

bertsky commented May 18, 2022

When running on a workspace with URL ending in anything but mets.xml, the input gets processed, but the METS is not updated.

The reason seems to be that the final ocrd workspace bulk-add command should use ocrd workspace -m ${ocrd__argv[mets]} bulk-add (but after we chdired we should strip the directory part).
@bertsky bertsky mentioned this issue May 18, 2022
Merged
@bertsky
Copy link
Collaborator Author

bertsky commented May 18, 2022

@kba I'm afraid this apply to all of our bashlib processors…

@kba kba closed this as completed in #41 Nov 10, 2022
@kba
Copy link
Member

kba commented Nov 10, 2022

@kba I'm afraid this apply to all of our bashlib processors…

Indeed, it does, cf. OCR-D/core#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-use METS basename for output bertsky/ocrd_fileformat
2 participants
@kba @bertsky