Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bashlib processing worker, require Python 3.7 #1024

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Mar 24, 2023

For #974

- for docstring extraction, add newlines after each block
- remove useless "wiring" of fileGrps
- add default values in brackets where applicable
- re-order logically (mets before grps)
- group processing and non-processing options for clarity
- fix the Processing Worker queue format
- improve formulations
and add `type=click.Path` for `--profile-file`.
(because they are cached/faster)
@bertsky bertsky requested review from kba and MehmedGIT March 24, 2023 23:37
- cimg needs sudo
- don't specify Python subminors, so it always picks latest
- activate docker_layer_caching for deploy to speed up
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Since I am usually spending my out of work time to read/comment/review stuff in github or with documentation, I will merge this potentially early next week when @kba approves as well.

ocrd_network/ocrd_network/deployer.py Show resolved Hide resolved
ocrd/ocrd/decorators/ocrd_cli_options.py Show resolved Hide resolved
ocrd/ocrd/processor/helpers.py Outdated Show resolved Hide resolved
ocrd/ocrd/processor/helpers.py Show resolved Hide resolved
ocrd/ocrd/processor/helpers.py Show resolved Hide resolved
@bertsky
Copy link
Collaborator Author

bertsky commented Mar 26, 2023

Does anyone know why there is no CI for the last commit here? Has our plan run out of capacity for this month incidentally?

Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
@kba
Copy link
Member

kba commented Mar 26, 2023

Does anyone know why there is no CI for the last commit here? Has our plan run out of capacity for this month incidentally?

Unable to parse YAML
while parsing a block collection
 in 'string', line 81, column 7:
          - checkout

Investigating.

@kba
Copy link
Member

kba commented Mar 26, 2023

Does anyone know why there is no CI for the last commit here? Has our plan run out of capacity for this month incidentally?

Unable to parse YAML
while parsing a block collection
 in 'string', line 81, column 7:
          - checkout

Investigating.

Fixed, there was a colon missing when you added the docker_layer_caching: true option to setup_remote_docker, it's runing now https://app.circleci.com/pipelines/github/OCR-D/core/1760/workflows/e57a7630-045f-4641-bca4-8e30f0ecc78e

But we are out of credits:

image

However, so far everything still seems to work. CI provider has been very generous so far, we've been over the quota basically every month for a long time, so I hope the generosity continues 🤞

@MehmedGIT MehmedGIT self-requested a review March 26, 2023 15:01
@MehmedGIT MehmedGIT merged commit eeaafc4 into dev-processing-broker Mar 26, 2023
@bertsky bertsky mentioned this pull request Mar 27, 2023
@bertsky bertsky deleted the dev-processing-broker-add-bashlib-processing-worker branch July 12, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants