-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bashlib processing worker, require Python 3.7 #1024
add bashlib processing worker, require Python 3.7 #1024
Conversation
- for docstring extraction, add newlines after each block - remove useless "wiring" of fileGrps - add default values in brackets where applicable - re-order logically (mets before grps) - group processing and non-processing options for clarity - fix the Processing Worker queue format - improve formulations
and add `type=click.Path` for `--profile-file`.
(because they are cached/faster)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Since I am usually spending my out of work time to read/comment/review stuff in github or with documentation, I will merge this potentially early next week when @kba approves as well.
Does anyone know why there is no CI for the last commit here? Has our plan run out of capacity for this month incidentally? |
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Investigating. |
…ttps://github.com/OCR-D/core into dev-processing-broker-add-bashlib-processing-worker
Fixed, there was a colon missing when you added the But we are out of credits: However, so far everything still seems to work. CI provider has been very generous so far, we've been over the quota basically every month for a long time, so I hope the generosity continues 🤞 |
For #974