Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 mets server did not support local_filename and url #1100

Merged
merged 2 commits into from
Sep 15, 2023
Merged

🔥 mets server did not support local_filename and url #1100

merged 2 commits into from
Sep 15, 2023

Conversation

kba
Copy link
Member

@kba kba commented Sep 15, 2023

No description provided.

@kba kba requested a review from MehmedGIT September 15, 2023 13:34
MehmedGIT
MehmedGIT approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

MehmedGIT
MehmedGIT requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the python 3.7 test failed, I think this is because of the low sleep in the test.

tests/test_mets_server.py Outdated Show resolved Hide resolved
@kba kba merged commit 97a05fa into master Sep 15, 2023
2 checks passed
@kba kba deleted the mets-server-fixes-2023-09-15-2 branch September 15, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MehmedGIT MehmedGIT MehmedGIT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @MehmedGIT