Fix/enhance configuration #630
Conversation
| @@ -52,6 +53,19 @@ handlers=consoleHandler | |||
| #handlers=fileHandler | |||
| #qualname=ocrd.workspace | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
The PIL restriction from the builtin config omitted because it is INFO anyway, correct?
There was a problem hiding this comment.
Yes, since it is the default level. But If you mind, I can add this as well
There was a problem hiding this comment.
Shall ocrd be integrated, too?
Be aware, this might have side-effects, because it is the far most top ocrd logging channel.
There was a problem hiding this comment.
Shall
ocrdbe integrated, too?
Be aware, this might have side-effects, because it is the far most top ocrd logging channel.
Since we don't specify logging behavior for ocrd* in the builtin config, we should not in the config file.
I also would leave the [logger_ocrd_workspace] commented out as an example - setting this to DEBUG by default will be very verbose.
There was a problem hiding this comment.
This makes sense, I adopt your suggestions asap
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
+ Coverage 84.82% 84.89% +0.06%
==========================================
Files 52 52
Lines 2952 2952
Branches 575 575
==========================================
+ Hits 2504 2506 +2
+ Misses 334 332 -2
Partials 114 114
Continue to review full report at Codecov.
|
Some draft regarding #621