Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependency python3-pip #813

Merged
merged 1 commit into from
May 3, 2022
Merged

Remove unneeded dependency python3-pip #813

merged 1 commit into from
May 3, 2022

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Mar 4, 2022

Signed-off-by: Stefan Weil sw@weilnetz.de

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@kba
Copy link
Member

kba commented Mar 4, 2022

We probably even only need python3-venv because it implies python3 doesn't it?

@stweil
Copy link
Contributor Author

stweil commented Mar 4, 2022

That's right, but the superfluous python3 won't cause installation of unneeded software (while python3-pip would, about 3 MB).

@bertsky
Copy link
Collaborator

bertsky commented Mar 4, 2022

Wait, can you show me proof / documentation that's true? (I often see the case that pip or pip3 in a venv points to the preinstalled version from the host system, not the venv.)

@stweil
Copy link
Contributor Author

stweil commented Mar 5, 2022

I haven't installed python3-pip on any of our systems where I have built OCR-D (Linux, macOS, Debian, Ubuntu, x86_64, arm, aarch64, Python 3.6, 3.7, 3.8, 3.9). pip or pip3 in the virtual environment is always a small script with less than 300 bytes .

@kba kba merged commit 5d996e9 into OCR-D:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants