Remove assets server #843
Merged
Remove assets server #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kba
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
And we should also remove it from https://github.com/OCR-D/assets/blob/master/Makefile#L38-L41
|
What's the rationale for removing that feature? |
The main purpose of it was to test the on-demand downloading, I haven't used it in years, was not aware anyone was using it and it's using the old python2 SimpleHTTPServer. |
|
Understood, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a brief discussion with @kba we observed that the
assets-serverfunctionality is obsolete because it is not used.This PR removes it as a consequence.