Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RESOURCE_LOCATIONS==module (for resmgr CLI) #932

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Oct 24, 2022

Another glitch that went under the radar. It must be possible to choose ocrd resmgr download -l module (even if module may already be the default, but it should at least appear as a CLI option).

@bertsky bertsky requested a review from kba October 24, 2022 22:59
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that it makes sense for consistency's sake, but is it realistic? If a processor has module as the default, it might make sense to override that to install to one of the standard location. But when would you want it the other way around?

@bertsky
Copy link
Collaborator Author

bertsky commented Oct 25, 2022

but is it realistic? If a processor has module as the default, it might make sense to override that to install to one of the standard location. But when would you want it the other way around?

Cannot think of a case. But there is a third scenario: modules that do not have module as default, but you would still want to install new models into the module directory if possible (because you want all files to be in one place, or because there is a standalone use outside of OCR-D).

@kba
Copy link
Member

kba commented Oct 25, 2022

but is it realistic? If a processor has module as the default, it might make sense to override that to install to one of the standard location. But when would you want it the other way around?

Cannot think of a case. But there is a third scenario: modules that do not have module as default, but you would still want to install new models into the module directory if possible (because you want all files to be in one place, or because there is a standalone use outside of OCR-D).

Agree, let's keep this flexible and consistent and not prevent any as of yet unanticipated use cases.

@kba kba merged commit 0ba3a4b into master Oct 25, 2022
@kba kba deleted the add-missing-resloc-module branch October 25, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants