Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wanted: /usr/bin/time in docker image #271

Closed
jbarth-ubhd opened this issue Jul 29, 2021 · 5 comments
Closed

wanted: /usr/bin/time in docker image #271

jbarth-ubhd opened this issue Jul 29, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@jbarth-ubhd
Copy link

No description provided.

@stweil stweil added the enhancement New feature or request label Nov 24, 2021
@stweil
Copy link
Collaborator

stweil commented Nov 24, 2021 •
edited
Loading

Are there any reasons against that suggestion? Installing the required time package will increase the storage need by 132 kb. That should not be a problem.

@kba
Copy link
Member

kba commented Nov 30, 2021

No, including time is not an issue of course. Should we add it to the ocrd_all Dockerfile or to the core base image? The latter probably, to make it available for all derived images?

@stweil
Copy link
Collaborator

stweil commented Nov 30, 2021

I agree that the latter looks like the better option.

@bertsky
Copy link
Collaborator

bertsky commented Nov 30, 2021

Yes, I'd argue the latter. (It would also give us the opportunity to implement ocrd.process.profile measurements from bashlib.)

kba added a commit to OCR-D/core that referenced this issue Nov 30, 2021
@kba
Dockerfile: install time for /usr/bin/time, OCR-D/ocrd_all#271
099d411
@kba
Copy link
Member

kba commented Feb 8, 2022

Fixed in OCR-D/core#748

@kba kba closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kba @stweil @jbarth-ubhd @bertsky