Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocrd cli: use make_file_id and assert_file_grp_cardinality #17

Merged
merged 3 commits into from
Aug 21, 2020
Merged

ocrd cli: use make_file_id and assert_file_grp_cardinality #17

merged 3 commits into from
Aug 21, 2020

Conversation

kba
Copy link
Member

@kba kba commented Aug 7, 2020

I hope I did not mess up the prev_file logic.

@bertsky bertsky self-requested a review August 14, 2020 18:08
bertsky
bertsky approved these changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I did not mess up the prev_file logic.

No, everything looks correct, and CI passes – thanks!

@kba kba merged commit e9c9cd8 into OCR-D:master Aug 21, 2020
@kba kba mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @bertsky