Stable ordering should be applied when using the EDM model for paging (in addition to EnableQueryAttribute.PageSize) #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (in addition to EnableQueryAttribute.PageSize).
|
@microsoft-github-policy-service agree company="Intermedia" |
|
@dmitry-chistyakov please add tests |
KenitoInc
requested review from
KenitoInc,
habbes,
mikepizzo,
xuzhg,
ElizabethOkerio and
gathogojr
|
Thank you @dmitry-chistyakov for your contribution. Could you please add tests to validate your change? |
Done. Please check. |
Done. Please check. |
KenitoInc
approved these changes
Oct 11, 2023
|
Thank you @dmitry-chistyakov for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use server-side paging feature and encountered an issue where OData applies stable ordering to the output dataset for $skip, $top, and EnableQueryAttribute.PageSize.
However, OData overlooks scenarios in which paging is defined through the EDM model, even though stable ordering logic should also be applied in such cases.
Although EnableQueryAttribute.PageSize is useful, it can become unwieldy in specific situations, especially when it propagates throughout all internal collections. This can lead to unexpected navigation through internal structures and retrieval of missing data. Additionally, issues may arise when constructing the @odata.nextLink for contained collections.