Set capacity for TruncatedCollection(IQueryable, int, boolean) overload

[senioroman4uk]

After profiling our service that uses AspNetCore.OData with a huge page size of 3000. I've noticed a lot of time is spent inside TruncatedCollection overload for IQueryable

Since it uses List as a base class current initialization will resize quite a few times before reaching the page size. This PR attempts to fix this for some of the overloads were size of the page is known

fixes #1185

[senioroman4uk]

@microsoft-github-policy-service agree company="Microsoft"

[senioroman4uk]

here are the results of the test I did with a sample server and bombardier

Bombarding https://localhost:7034/odata/Products for 1m0s using 10 connection(s)
Before

After

Note that for smaller lists (less than 16 pre-allocating will be slower or showing no effect)

[senioroman4uk]

fixes #1185

[julealgon]

Would it make sense to do something like this to avoid the same calculation again (and opening it up for potential inconsistencies in the future)?

Suggested change

	var items = source.Take(checked(pageSize + 1));
	var items = source.Take(Capacity);

[senioroman4uk]

You are right, applied

[gathogojr]

Thank you @senioroman4uk for your pull request contribution. It looks like a great optimization. However, I don't know if applying the Obsolete attribute to some of the constructors without a good understanding of the use cases they were intended for was a good idea since that action introduced extra things/changes to debate about. I hope it won't cause unnecessary delays.

[gathogojr]

@senioroman4uk You need to update the public API files

[habbes]

@senioroman4uk please fix the PublicApiOut tests:

[senioroman4uk]

Updated public api files

[senioroman4uk]

@habbes @xuzhg, can you please re-review I have addressed your suggestions

[habbes]

Not a major issue, I think this is .NET Framework's code. Might be more relevant to reference the current .NET's code: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/List.cs#L23

[senioroman4uk]

updated

[senioroman4uk]

@gathogojr applied your suggestions, please give it another review when you have a chance