Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #587: AddODataNewtonsoftJson should call AddODataNewtonsoftJson with null #589

Merged
merged 1 commit into from
May 5, 2022

Conversation

xuzhg
Copy link
Member

@xuzhg xuzhg commented May 3, 2022

#587

Fix the issue by calling AddODataNewtonsoftJson with null.

Add the test cases.

@xuzhg xuzhg linked an issue May 3, 2022 that may be closed by this pull request
@corranrogue9
Copy link
Contributor

It is normal for there to be test failures but for the build to succeed?

@xuzhg
Copy link
Member Author

xuzhg commented May 4, 2022

Abnormal. Where do you see 'test failures but the build succeeded"?

Copy link
Contributor

@gathogojr gathogojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@xuzhg xuzhg merged commit 3df3a0b into main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentNullException when calling AddODataNewtonsoftJson()
3 participants