Maintain case for parameter alias in generated nextlink #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gathogojr
requested review from
KenitoInc,
habbes,
xuzhg,
corranrogue9,
ElizabethOkerio and
lisicase
habbes
approved these changes
Nov 8, 2022
| // Arrange | ||
| var requestUri = "/prefix/ServerSidePagingEmployees/" + | ||
| "GetEmployeesHiredInPeriod(fromDate=@fromDate,toDate=@toDate)" + | ||
| "?@fromDate=2023-01-07T00:00:00%2B00:00&@toDate=2023-05-07T00:00:00%2B00:00"; |
There was a problem hiding this comment.
Does this change affect query options?
There was a problem hiding this comment.
@habbes It doesn't affect OData query options. This means that if the there was $ORDERBY on the request URL (I don't know if it's allowed), it'll be returned as $orderby on the @odata.nextLink in the response body. I think that should be okay
ElizabethOkerio
approved these changes
Nov 14, 2022
gathogojr
deleted the
fix/2493-maintain-case-for-parameter-alias-in-nextlink
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes OData/WebApi#2493.
Description
Maintain case for parameter alias in generated nextLink
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.