Potential fix for issue #616 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
@xuzhg did you have a chance to take a look at this PR ? Thanks |
KenitoInc
requested review from
KenitoInc,
habbes,
xuzhg,
ElizabethOkerio and
gathogojr
|
Hi @KenitoInc , |
|
@KenitoInc , it was not as much a hassle as I thought :) . Hope this new commit fulfils your requirements |
KenitoInc
reviewed
Jun 8, 2023
test/Microsoft.AspNetCore.OData.Tests/Query/Query/DefaultSkipTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
…` is used in query
gathogojr
reviewed
Jun 26, 2023
src/Microsoft.AspNetCore.OData/Query/Query/DefaultSkipTokenHandler.cs
Outdated
Show resolved
Hide resolved
You're welcome ! @KenitoInc, do you agree with the overall changes ? |
KenitoInc
approved these changes
Jun 30, 2023
|
@orty Thanks for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #616 which I also encountered, I would like to propose this fix.
As I am not completely aware of side-effects that using only
edmProperty.Namecould have, I relied on a safe way to rollback to the EDM property name instead of the CLR one if the latter is not found.https://github.com/OData/AspNetCoreOData/blob/10a246671b6312fd234151c47cc91787da5cb171/src/Microsoft.AspNetCore.OData/Query/Query/DefaultSkipTokenHandler.cs#LL136C1-L145C18
I tested this change with my current project, but I suspect that some unit tests might have to be "doubled" with a
builder.EnableLowerCamelCase()scenario to check for regressions on property retrieval when using a lowercased convention.edit: Also tested along with the
[DataContract]and[DataMember]attributes which create aliases for properties.