Feature/ted 39 #12
Merged
Feature/ted 39 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 94.94% 95.01% +0.07%
==========================================
Files 19 19
Lines 336 341 +5
==========================================
+ Hits 319 324 +5
Misses 17 17
Continue to review full report at Codecov.
|
costezki
approved these changes
Feb 17, 2022
tests/e2e/notice_fetcher/conftest.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def notice_repository(): |
There was a problem hiding this comment.
Do not duplicate fixtures.
The fixture resolution is hierarchical. So remove this one because it is defined in the parent package conftest.py
tests/e2e/notice_fetcher/conftest.py
Outdated
| def notice_repository(): | ||
| return FakeNoticeRepository() | ||
|
|
||
| @pytest.fixture |
| from ted_sws.notice_fetcher.services.notice_fetcher import NoticeFetcher | ||
|
|
||
|
|
||
| def test_notice_fetcher_by_identifier(): | ||
| def test_notice_fetcher_by_identifier(notice_repository, ted_document_search): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.