Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 588 #218

Merged
merged 9 commits into from
Aug 30, 2022
Merged

Feature/ted 588 #218

merged 9 commits into from
Aug 30, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #218 (34b32d1) into main (51b9cf8) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   98.70%   98.66%   -0.05%     
==========================================
  Files         115      108       -7     
  Lines        5030     4864     -166     
==========================================
- Hits         4965     4799     -166     
  Misses         65       65              
Impacted Files Coverage Δ
...ices/conceptual_mapping_generate_sparql_queries.py 100.00% <ø> (ø)
ted_sws/core/adapters/cmd_runner.py 100.00% <100.00%> (ø)
ted_sws/core/model/manifestation.py 100.00% <100.00%> (ø)
ted_sws/core/model/supra_notice.py 100.00% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/notice_repository.py 96.96% <100.00%> (+0.01%) ⬆️
...s/data_manager/adapters/supra_notice_repository.py 100.00% <100.00%> (ø)
.../entrypoints/cli/cmd_generate_mapping_resources.py 100.00% <100.00%> (ø)
ted_sws/event_manager/adapters/log/__init__.py 100.00% <100.00%> (ø)
ted_sws/mapping_suite_processor/__init__.py 100.00% <100.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent. BUT way too many files in the PR.
It seems that this PR shall have been split into three:

  • implementation of the SPARL validation summarisation
  • refactoring/cleanup of the logger
  • implementation of the "replace-digest-url" service

@@ -8,8 +8,7 @@
EventWriterToMongoDBHandler
from ted_sws.event_manager.adapters.event_handler_config import CLILoggerConfig
from ted_sws.event_manager.adapters.event_logger import EventLogger
from ted_sws.event_manager.adapters.log import SeverityLevelType
from ted_sws.event_manager.adapters.logger import LOG_ERROR_TEXT, LOG_SUCCESS_TEXT
from ted_sws.event_manager.adapters.log import SeverityLevelType, LOG_ERROR_TEXT, LOG_SUCCESS_TEXT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module seems to be something that belongs to the entry points, not adapters

from ted_sws import config


def update_digest_api_address_for_mapping_suite(mapping_suite: MappingSuite,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good documentation.

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@CaptainOfHacks CaptainOfHacks merged commit 5ecd456 into main Aug 30, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-588 branch August 30, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants