notice collection mat view #298

Dragos0000 · 2022-10-10T14:14:14Z

No description provided.

swarmia · 2022-10-10T14:14:24Z

✅ Linked to TED-822 · create mat view for notice collection
➡️ Part of Story TED-819 · develop a script which creates indexes and materialized views
➡️ Part of Epic TED-268 · WP2.3 Notice Transformation Service P2

kaleanych

Looks good

codecov-commenter · 2022-10-10T14:25:10Z

Codecov Report

Base: 99.01% // Head: 99.01% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0ceaddc) compared to base (4904633).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         106      107    +1     
  Lines        5485     5493    +8     
=======================================
+ Hits         5431     5439    +8     
  Misses         54       54

Impacted Files	Coverage Δ
...ices/create_notice_collection_materialised_view.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

costezki · 2022-10-10T15:05:02Z

tests/e2e/data_manager/test_mongodb_client.py

@@ -143,3 +145,12 @@ def test_mongo_db_query_2():
    ])
    for r in result:
        print(r)
+


No need to anything (print(r)) in tests

costezki · 2022-10-10T15:05:16Z

tests/e2e/data_manager/test_mongodb_client.py

+    create_notice_collection_materialised_view(mongo_client=mongodb_client)
+    db = mongodb_client[config.MONGO_DB_AGGREGATES_DATABASE_NAME]
+    assert NOTICES_MATERIALISED_VIEW_NAME in db.list_collection_names()
+    assert 'form_number', 'form_type' in db[NOTICES_MATERIALISED_VIEW_NAME].find_one().keys()
