New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update code to new TED-API version #339

Merged

CaptainOfHacks merged 6 commits into main from feature/TED-914

Nov 3, 2022

Collaborator

CaptainOfHacks commented Nov 2, 2022

No description provided.


          update code to new TED-API version

96ac884

CaptainOfHacks requested review from kaleanych, costezki and Dragos0000

November 2, 2022 20:14

swarmia bot commented Nov 2, 2022

✅ Linked to Task TED-914 · Revise TED-API new version, update all code to new TED-API version

costezki approved these changes

View reviewed changes

Collaborator

costezki left a comment

No ints pls

ted_sws/core/model/metadata.py Outdated

@@ @@ -103,9 +105,15 @@ class TEDMetadata(Metadata): @@
                   PD: str = None
                   PR: str = None
                   RC: List[str] = None
-                  RN: int = None
+                  RN: List[int] = None

Collaborator

costezki Nov 2, 2022

No ints pls only str


          fix unit tests

88fd04a

kaleanych approved these changes

View reviewed changes

CaptainOfHacks added 3 commits

November 2, 2022 23:29


          fix unit tests

e38c985


          Update test_notice_repository.py

c589642


          Update test_creating_notice.py

227d19b

costezki approved these changes

View reviewed changes

tests/conftest.py

@@ @@ -90,8 +90,7 @@ def notice_2015(): @@
               @pytest.fixture
               def notice_2018():
                   notice_data = read_notice("045279-2018.json")
-                  notice_content = base64.b64decode(notice_data["content"]).decode(encoding="utf-8")
-                  xml_manifestation = XMLManifestation(object_data=notice_content)
+                  xml_manifestation = XMLManifestation(object_data=notice_data["content"])

Collaborator

costezki Nov 3, 2022

looks cleaner


          Update 396207_2018.json

5b4f76d

sonarcloud bot commented Nov 3, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

0.0% Coverage
0.0% Duplication

CaptainOfHacks merged commit 09d1086 into main

CaptainOfHacks deleted the feature/TED-914 branch

November 3, 2022 08:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet