Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ted 896 #345

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Feature/ted 896 #345

merged 7 commits into from
Nov 8, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

@swarmia
Copy link

swarmia bot commented Nov 7, 2022

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Base: 99.11% // Head: 99.04% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (cb46591) compared to base (e73ea9b).
Patch coverage: 91.30% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   99.11%   99.04%   -0.08%     
==========================================
  Files         119      119              
  Lines        6000     6048      +48     
==========================================
+ Hits         5947     5990      +43     
- Misses         53       58       +5     
Impacted Files Coverage Δ
...processor/services/mapping_suite_digest_service.py 100.00% <ø> (ø)
...ter_data_registry/services/entity_deduplication.py 94.11% <50.00%> (-4.82%) ⬇️
ted_sws/core/model/metadata.py 100.00% <100.00%> (ø)
ted_sws/core/model/supra_notice.py 100.00% <100.00%> (ø)
ted_sws/core/model/transform.py 100.00% <100.00%> (ø)
ted_sws/data_manager/adapters/triple_store.py 97.08% <100.00%> (+0.02%) ⬆️
...ices/create_notice_collection_materialised_view.py 100.00% <100.00%> (ø)
...notice_publisher/adapters/sftp_notice_publisher.py 100.00% <100.00%> (ø)
..._sws/notice_publisher/services/notice_publisher.py 100.00% <100.00%> (ø)
...ansformer/entrypoints/api/digest_service/server.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the validation bug shall touch on fewer files than this.
Probably there are multiple issues implemented by this PR

@@ -19,7 +19,8 @@
DEFAULT_NUBER_OF_CELERY_WORKERS = 144
NOTICE_PROCESS_WORKFLOW_DAG_NAME = "notice_process_workflow"
DEFAULT_START_WITH_TASK_ID = "notice_normalisation_pipeline"
DEFAULT_PIPELINE_NAME_FOR_LOGS = "unknown_pipeline_name"
DEFAULT_PIPELINE_NAME_FOR_LOGS = "unknown_pipeline_name"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is merged from main. ask Stefan

Copy link
Collaborator

@CaptainOfHacks CaptainOfHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge main into current branch, before merge into main.

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kaleanych kaleanych merged commit 8fa9052 into main Nov 8, 2022
@kaleanych kaleanych deleted the feature/TED-896 branch November 8, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants