Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor data model, add lazy fields, refactor repositories #436

Merged
merged 13 commits into from
Feb 7, 2023

Conversation

CaptainOfHacks
Copy link
Collaborator

No description provided.

@swarmia
Copy link

swarmia bot commented Feb 1, 2023

✅  Linked to Story TED-1211 · Redesign MongoDB schema/storage

Copy link
Collaborator

@costezki costezki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, monkey business.

We cannot have a Clean Model, apparently.

@codecov-commenter
Copy link

Codecov Report

Base: 98.19% // Head: 98.11% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (486bf79) compared to base (ba37f66).
Patch coverage: 96.09% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   98.19%   98.11%   -0.08%     
==========================================
  Files         128      131       +3     
  Lines        6633     6904     +271     
==========================================
+ Hits         6513     6774     +261     
- Misses        120      130      +10     
Impacted Files Coverage Δ
...entrypoints/cli/cmd_export_notices_from_mongodb.py 97.29% <ø> (-0.08%) ⬇️
...d_sws/data_manager/adapters/metadata_repository.py 93.24% <93.24%> (ø)
ted_sws/data_manager/adapters/notice_repository.py 95.48% <93.93%> (-0.36%) ⬇️
ted_sws/core/model/lazy_object.py 94.73% <94.73%> (ø)
...metadata_processor/services/metadata_normalizer.py 98.11% <95.00%> (-0.47%) ⬇️
.../data_manager/adapters/manifestation_repository.py 95.12% <95.12%> (ø)
ted_sws/core/model/metadata.py 100.00% <100.00%> (ø)
ted_sws/core/model/notice.py 100.00% <100.00%> (+0.50%) ⬆️
ted_sws/data_manager/adapters/repository_abc.py 100.00% <100.00%> (ø)
ted_sws/data_sampler/services/notice_selectors.py 93.75% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CaptainOfHacks CaptainOfHacks merged commit 2d992ec into main Feb 7, 2023
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-1211 branch February 7, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants