Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor notice packager #444

Merged
merged 3 commits into from
Feb 15, 2023
Merged

refactor notice packager #444

merged 3 commits into from
Feb 15, 2023

Conversation

CaptainOfHacks
Copy link
Collaborator

No description provided.

@swarmia
Copy link

swarmia bot commented Feb 15, 2023

✅  Linked to Task TED-1219 · Update the METS test packages generator

@codecov-commenter
Copy link

Codecov Report

Base: 96.29% // Head: 96.24% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (561d231) compared to base (f2d759e).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   96.29%   96.24%   -0.05%     
==========================================
  Files         106      106              
  Lines        5582     5536      -46     
==========================================
- Hits         5375     5328      -47     
- Misses        207      208       +1     
Impacted Files Coverage Δ
ted_sws/notice_packager/adapters/archiver.py 100.00% <100.00%> (ø)
...sws/notice_packager/adapters/template_generator.py 100.00% <100.00%> (ø)
...ed_sws/notice_packager/services/notice_packager.py 97.10% <100.00%> (-2.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's working is nice

@CaptainOfHacks CaptainOfHacks merged commit 2a4a48c into main Feb 15, 2023
@costezki costezki deleted the feature/TED-1219 branch February 21, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants