Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate TED-API v3 and add eForms sample data #518

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

CaptainOfHacks
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needs to be fixed


return self.get_by_query(query=query)

def get_by_query(self, query: dict, result_fields: dict = None) -> List[dict]:
def _retrieve_document_content(self, document_content: dict) -> str:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test for this function?

else:
raise Exception(f"The notice content can't be loaded!: {response}, {response.content}")

def get_generator_by_query(self, query: dict, result_fields: dict = None) -> Generator[dict, None, None]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a test for this function?

@Dragos0000 Dragos0000 self-requested a review February 14, 2024 13:30
@CaptainOfHacks CaptainOfHacks merged commit 4ced645 into main Feb 14, 2024
3 checks passed
@CaptainOfHacks CaptainOfHacks deleted the feature/TED4-101 branch February 14, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants