Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ted 83 #8

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Feature/ted 83 #8

merged 7 commits into from
Feb 11, 2022

Conversation

CaptainOfHacks
Copy link
Collaborator

  • add NoticeRepositoryABC
  • add FakeNoticeRepository
  • add tests

@gitguardian
Copy link

gitguardian bot commented Feb 11, 2022

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

Dragos0000
Dragos0000 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@Dragos0000 Dragos0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@CaptainOfHacks CaptainOfHacks merged commit b1784e7 into main Feb 11, 2022
@CaptainOfHacks CaptainOfHacks deleted the feature/TED-83 branch February 11, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragos0000 Dragos0000 Dragos0000 approved these changes

@costezki costezki Awaiting requested review from costezki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaptainOfHacks @Dragos0000