Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI tools documentation #84

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Added CLI tools documentation #84

merged 6 commits into from
Apr 26, 2022

Conversation

kaleanych
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #84 (c3dd05f) into main (4cb51f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c3dd05f differs from pull request most recent head 93ff9ce. Consider uploading reports for the commit 93ff9ce to get more accurate results

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          59       59           
  Lines        2366     2381   +15     
=======================================
+ Hits         2344     2359   +15     
  Misses         22       22           
Impacted Files Coverage Δ
ted_sws/core/adapters/cmd_runner.py 100.00% <100.00%> (ø)
...ager/entrypoints/cmd_generate_mapping_resources.py 100.00% <100.00%> (ø)
...ocessor/entrypoints/cmd_mapping_suite_processor.py 100.00% <100.00%> (ø)
...te_processor/entrypoints/cmd_metadata_generator.py 100.00% <100.00%> (ø)
...uite_processor/entrypoints/cmd_sparql_generator.py 100.00% <100.00%> (ø)
...processor/entrypoints/cmd_yarrrml2rml_converter.py 100.00% <100.00%> (ø)
...ormer/entrypoints/cmd_mapping_suite_transformer.py 100.00% <100.00%> (ø)
.../notice_eligibility/services/notice_eligibility.py 97.36% <0.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c83f81...93ff9ce. Read the comment docs.

Copy link
Contributor

@csnyulas csnyulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that the RML mapping file is called "mappings.rml.ttl" and not "output.rml.ttl" in the code (and make sure the CLI tools work with those names :) ).

See for example:
58b5831#diff-e92768c2ab48cd9b2c5d4006f7fb418eca719f56c8da494add0f11149532ee14
and
https://github.com/meaningfy-ws/ted-sws/pull/84/files#diff-c6928e509891b77e660da91efc11c53fce305cdd32c9d49349b75d2e28ec877f

Copy link
Contributor

@csnyulas csnyulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve it for now, but the RML file name issue pointed out before should be resolved in the next round.

@csnyulas csnyulas merged commit 656d034 into main Apr 26, 2022
@costezki costezki deleted the feature/TED-304 branch April 27, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants