Add support for GRUPSLAV

[hakonhagland]

See OPM/opm-simulators#5436 and OPM/opm-simulators#5443 for more information.

[hakonhagland]

jenkins build this opm-simulators=5443 please

[hakonhagland]

jenkins build this opm-simulators=5443 please

[hakonhagland]

jenkins build this opm-simulators=5443 please

[totto82]

Looks good to me

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

The jenkins build console output reports:

Repository revisions:
	​[main module] opm-common=origin/pr/4123/merge
	 [downstream] opm-grid=master
	 [downstream] opm-models=master
	 [downstream] opm-simulators=pull/5453/merge

[...]

​simulators/opm/simulators/flow/SimulatorFullyImplicitBlackoil.hpp:27:10: fatal error: opm/input/eclipse/Schedule/ResCoup/ReservoirCouplingInfo.hpp: No such file or directory
   ​27 | #include <opm/input/eclipse/Schedule/ResCoup/ReservoirCouplingInfo.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

But that file opm/input/eclipse/Schedule/ResCoup/ReservoirCouplingInfo.hpp is actually present in the current PR, see here.. @akva2 Any ideas?

[akva2]

yes. you have to add it to the installed header list in CMakeLists_files.cmake.

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

The Jeninks tests reports a segmentation fault:

[opm-deb:2741637] Signal: Segmentation fault (11)
[opm-deb:2741637] Signal code: Address not mapped (1)
[opm-deb:2741637] Failing at address: 0x90

It seems this is because the ptr_member rescoup:

opm-common/opm/input/eclipse/Schedule/ScheduleState.hpp

Line 404 in d5ea3ac

ptr_member<ReservoirCoupling::CouplingInfo> rescoup;

will refer to a nullptr if not rescoup.update() has been called and in OPM/opm-simulators#5453
I try to access this in that case (update() has not been called). What I need to do is something like this:

if (this->schedule()[0].rescoup()) {
     auto master_mode = this->schedule()[0].rescoup().masterMode();
    // ....
}

but this will not compile since rescoup() returns a const T& and not a pointer. Do I need to modify ptr_member or am I missing something? For example, by adding a empty() method:

bool empty() const {
      return !this->m_data;
}

Then, I could do:

if (!this->schedule()[0].rescoup.empty()) {
     auto master_mode = this->schedule()[0].rescoup().masterMode();
    // ....
}

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

The Jeninks tests reports a segmentation fault

Seems like real the problem was that I had forgot to add reservoir coupling information to the Schedule serialization object, so the rescoup ptr_member became nullptr on all ranks except for rank 0.

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

jenkins build this opm-simulators=5453 please

[blattms]

I had another look, This was approved before and I am ready to merge.

I am just wondering about some comments and possible code simplifaction. I seems like those comments are related to code that was not even changed by this PR but just moved. Would still be cool if you would double check my comments and the places.

I will run jenkins on this alone, too,

[blattms]

jenkins build this please

[hakonhagland]

jenkins build this please

[hakonhagland]

I will run jenkins on this alone, too,

@blattms I think this PR should be merged at the same time as OPM/opm-simulators#5453 is merged. Currently the jenkins build fails when using opm-simulators master branch, but it succeeds if building against OPM/opm-simulators#5453. This is because that PR includes the missing headers needed for schedule serialization.

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

jenkins build this opm-simulators=5453 please

[hakonhagland]

jenkins build this opm-simulators=5521 please

[hakonhagland]

Rebased

[hakonhagland]

jenkins build this opm-simulators=5521 please

[hakonhagland]

jenkins build this opm-simulators=5521 please

[blattms]

Lots of approvals. Is there a reason not to merge this without the rest?

Let's ask jenkins.

[blattms]

jenkins build this please

[hakonhagland]

Is there a reason not to merge this without the rest?

@blattms For the jenkins build to pass, we need to first merge some PRs in opm-simulators: OPM/opm-simulators#5436, OPM/opm-simulators#5437, OPM/opm-simulators#5443, OPM/opm-simulators#5453, and OPM/opm-simulators#5521

[hakonhagland]

jenkins build this opm-simulators=5620 please

[hakonhagland]

The Jenkins build reports 6 test failures:

I can run all of those test cases locally, except the case compareECLFiles_flow_blackoil_float+SPE1CASE1. Here I get,

$ ctest -N  | grep SPE1CASE1
  Test #107: compareECLFiles_flow+SPE1CASE1
  Test #108: compareECLFiles_flow+SPE1CASE1_IMPORT
  Test #113: compareECLFiles_flow+SPE1CASE1_BRINE
  Test #114: compareECLFiles_flow+SPE1CASE1_PRECSALT
  Test #122: compareECLFiles_flow+SPE1CASE1_METRIC_VFP1
  Test #123: compareECLFiles_flow+SPE1CASE1_WATER
  Test #358: compareParallelSim_flow+SPE1CASE1_WATER
  Test #359: compareParallelSim_flow+SPE1CASE1_BRINE

@akva2 Do you know how to run test case compareECLFiles_flow_blackoil_float+SPE1CASE1 ?

[akva2]

you have to build with cmake parameter -DBUILD_FLOW_FLOAT_VARIANTS=1

[hakonhagland]

jenkins build this opm-simulators=5620 please