Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple meters per meter group for Solar #306

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Mar 5, 2024

It seems that by the time PacificPower meters get to meter_group.js file, they are accumulated_real measurement type anyways.

However, it could be good to handle case for solar meters in the future regardless.

image

Other notes for adding multiple meters to Radiation Center meter group:
(This may be a good indication of future potential issues of supporting multiple-meter meter groups with solar energy type, since PacificPower uses energy_change initially)

  • Measurement type is accumulated_real by the time it reaches src/store/meter_group.js, so multiple meters can be combined into one meter group for PacificPower meters without any issue
  • Adding up accumulated_real values for various days seemed to sum up values from 3 meters as expected, and Inspect Element > Network makes 3 API calls at https://dashboard.sustainability.oregonstate.edu/#/building/59/2
    • For February 15 (Unix: 1708041599), meters 129 and 139 have data while meter 148 does not. As expected, the accumulated_real value shown for February 15 (for the Radiation Center meter group) is the sum of meters 129 and 139 only.

@solderq35 solderq35 requested a review from s-egge March 5, 2024 19:10
@s-egge s-egge merged commit 2431c15 into master Mar 8, 2024
3 checks passed
@s-egge s-egge deleted the multiple-meters-group-solar branch July 1, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants