Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poling campaign fix #317

Merged
merged 1 commit into from
Apr 23, 2024
Merged

poling campaign fix #317

merged 1 commit into from
Apr 23, 2024

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Apr 23, 2024

Issue

  • [2024 Kilowatt Crackdown] Poling Hall Weird Values on Graph #318
  • Poling Hall (as of April 22, 2024) shows percentages of 400 or 500% energy savings (implausibly high), as shown below
  • This is related to this old PR from last year
    • The objective of that PR was to try to fix Weatherford from the 2022 campaign to show up, which might also lead to the possibility of supporting manually uploading data for a particular building in a campaign (the original issue with Weatherford was that because the data was manually uploaded in SQL, the data was only uploaded in hourly increments while the database expected 15 minute values)
    • However, the findClosest function (at least in baseline_perc.js file) is not working as expected (you can see my old comments in this file about something not working quite right for 1 day / 6 hours)
      • I couldn't get Weatherford to show up on the 1 day / 6 hours graphs of the 2022 campaign either (although that may just be due lack of Weatherford data on the last day of 2022 campaign)

Potential Solutions

  • Option 1 (current): Just remove any references to findClosest function (and related variables etc) in src\store\chart_modifiers\line_bar\baseline_perc.js file

    • It is not vital that Weatherford shows up on the 2022 campaign (and as mentioned above, it didn't seem to work for 1 day / 6 hours anyways), and if the Office wants to support manually uploaded campaign data in the future, that can be handled via a new and better fix in the future
    • Fairly certain that baseline_perc.js file is only used by the campaigns, although that should be double checked
    • I don't think there are currently any issues with other files that use findClosest function (e.g. accumulated_real.js, energy_change.js)
  • Option 2: Try to fix the logic for the findClosest function in the baseline_perc.js file

    • Probably not feasible unless a very simple fix is found within a day or two, since it is important to get the campaign online and in mostly-working order ASAP)

Screenshots

Before

image

After

image

@solderq35 solderq35 requested a review from s-egge April 23, 2024 01:09
@solderq35 solderq35 added priority-high data-layer Includes cache, API calls, or data transformations in VueX and removed priority-high data-layer Includes cache, API calls, or data transformations in VueX labels Apr 23, 2024
@solderq35 solderq35 linked an issue Apr 23, 2024 that may be closed by this pull request
@s-egge s-egge merged commit bc60cc0 into master Apr 23, 2024
3 checks passed
@s-egge s-egge deleted the poling-campaign-fix branch July 1, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024 Kilowatt Crackdown] Poling Hall Weird Values on Graph
2 participants