Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
baseline_perc.js
file) is not working as expected (you can see my old comments in this file about something not working quite right for 1 day / 6 hours)Potential Solutions
Option 1 (current): Just remove any references to
findClosest
function (and related variables etc) insrc\store\chart_modifiers\line_bar\baseline_perc.js
filebaseline_perc.js
file is only used by the campaigns, although that should be double checkedfindClosest
function (e.g.accumulated_real.js
,energy_change.js
)Option 2: Try to fix the logic for the
findClosest
function in thebaseline_perc.js
fileScreenshots
Before
After