Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix firefox active tab highlight bug #328

Merged
merged 1 commit into from
May 13, 2024
Merged

fix firefox active tab highlight bug #328

merged 1 commit into from
May 13, 2024

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented May 13, 2024 •
edited
Loading

Issue

Changes

  • Removed margin-left: -10px and margin-right: -10px from navbar component, which was what caused the bug
  • Also shortened "Building List" to just "Buildings", partly because the "Building List" text would render on 2 lines without negative margins (on mobile device resolutions, like 600px wide screen), and partly because it's not like we show "Campaign List" instead of "Campaigns
  • Also replaced "Building List" with "Buildings" in the FAQ ("getting started") tab
  • Actual component names or code comments referencing "building list" were not changed

Screenshots

PC Browser, Firefox

image

Mobile Browser, Safari

image

@solderq35 solderq35 requested a review from s-egge May 13, 2024 07:02
s-egge
s-egge approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@s-egge s-egge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good on Firefox, Chrome, and mobile.

@s-egge s-egge merged commit d462296 into master May 13, 2024
3 checks passed
@s-egge s-egge deleted the fix-firefox-active-tabs branch May 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-egge s-egge s-egge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FireFox building button padding css issue
2 participants
@solderq35 @s-egge