-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made language selection understandable #822
Conversation
Superb to see this , many thanks @raghav1030
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to see this change - tested and works as described
some unit tests now fail due to changes in text, but that is easy to fix up
Hey @jgadsden! I have updated the tests for locale select and now it is passing all the tests. Would love to know if there's any other feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @raghav1030 , all good to merge now
Going ahead with merge, the remaining failing test is is the usual 'lack of permissions' failure |
Summary:
This PR changes the way languages are getting rendered. Initially the languages in the locale select dialog box was getting rendered by 3 letter ISO codes but now they have been locally transliterated into the respective language.
The update fixes a part of all the issues mentioned in #806. This PR changes the way languages are getting rendered.
Description for the changelog:
language selection dropdown menu uses natural language
Other info:
closes #806