Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print device by family function #205
Print device by family function #205
Changes from 13 commits
2b07232
28cec71
896a490
a8eb114
1bed72e
1823926
436eeab
7d75f95
77b82c2
d3b9bf9
14081eb
0820291
2b9e8e4
2f81bba
8985ff7
1298063
6ce3f54
e7d3577
5a263a6
eb4e24c
b66eb58
5b800fe
4f3dc56
8aed69d
22358c6
df3f206
216ff8d
1a90d7a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not what the function is doing. See https://markdewing.github.io/blog/posts/notes-on-cmake/
outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MATCHES
is for regex. HereEQUAL
may be more appropriatehttps://cmake.org/cmake/help/latest/command/if.html#matches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be handled by
cmake_parse_arguments
see https://cmake.org/cmake/help/latest/command/cmake_parse_arguments.html<prefix>_KEYWORDS_MISSING_VALUES
and<prefix>_UNPARSED_ARGUMENTS
I think it will be safer and avoid unexpected corner cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe all checks are done in stm32_get_devices_by_family.