Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic family matrix for CI jobs #342

Merged
merged 4 commits into from
Jul 7, 2024

Conversation

xanthio
Copy link
Contributor

@xanthio xanthio commented May 24, 2024

In the objective of getting more contribution, these changes create the family matrix at CI run time.

I will be easier for a non CI-friendly contributor to add a new family to project as they won't have to make change in the workflow files.

Updating the Test workflow was the opportunity to update the deprecated checkout action step.

@xanthio
Copy link
Contributor Author

xanthio commented May 24, 2024

I guess it would be a good idea to split Fetch/CMSIS/HAL in individual jobs too.

@Hish15
Copy link
Collaborator

Hish15 commented Jun 3, 2024

@atsju, I speak unix so I'm not shocked here. Can you have a look please?

@atsju
Copy link
Collaborator

atsju commented Jun 3, 2024

Indeed, extensive comments are welcome.
I would appreciate ELI5 comments but I let your @Hish15 decide if it's needed or not. As I understand, someone speaking Unix would not need any comment.

@xanthio
Copy link
Contributor Author

xanthio commented Jun 3, 2024

Actually its not so understandable for someone who is not a unix user.
I can split Create matrix step so the new steps names will comment the work that is done.

@xanthio xanthio force-pushed the maintenance/dynamic-matrixing branch from 9b4a624 to f546e4c Compare June 5, 2024 08:26
@xanthio xanthio force-pushed the maintenance/dynamic-matrixing branch from f546e4c to e067e06 Compare June 5, 2024 08:30
@xanthio
Copy link
Contributor Author

xanthio commented Jun 5, 2024

In fact not easy to split as steps use list variable that github action can not handle.
That is why I was using JSON object as recommended https://docs.github.com/en/actions/learn-github-actions/expressions#example-returning-a-json-object

@Hish15 Hish15 merged commit d8f9e07 into ObKo:master Jul 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants