Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new libp2p metrics to relay #2544

Closed
corverroos opened this issue Aug 14, 2023 · 1 comment
Closed

add new libp2p metrics to relay #2544

corverroos opened this issue Aug 14, 2023 · 1 comment
Assignees
Labels
protocol Protocol Team tickets V1

Comments

@corverroos
Copy link
Contributor

🎯 Problem to be solved

libp2p added a bunch of new circuit relay metrics as part of there v0.27.0 release. We should instrument these to make detecting issues with relay easier for operators.

🛠️ Proposed solution

Determine which metrics to enable and enable it.

@github-actions github-actions bot added the protocol Protocol Team tickets label Aug 14, 2023
@boulder225 boulder225 added the V1 label Mar 1, 2024
@gsora
Copy link
Collaborator

gsora commented Mar 14, 2024

Hey team! Please add your planning poker estimate with Zenhub @KaloyanTanev @pinebit

@pinebit pinebit self-assigned this Apr 11, 2024
@pinebit pinebit closed this as completed Apr 16, 2024
obol-bulldozer bot pushed a commit that referenced this issue Apr 16, 2024
libp2p introduced set of new metrics for relay:
https://github.com/libp2p/go-libp2p/blob/master/p2p/protocol/circuitv2/relay/metrics.go

This work integrates these metrics into our instrumentation flow.

Note: metrics reported by libp2p will be prefixed: `libp2p_relaysvc` whereas metrics reported by charon code are prefixed: `relay_p2p`. This distinction seems useful for clear separation and avoiding clashes. Therefore, `metrics.md` remains intact. This only enriches libp2p metrics with charon cluster labels.

category: feature
ticket: #2544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets V1
Projects
None yet
Development

No branches or pull requests

4 participants