Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/protonil: implement generic nil proto checker #2344

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jun 21, 2023

Implements a generic protobuf nil checker to mitigate against manual verbose or buggy protobuf nil checks.

Note this requires fields that allowed to be nil to be specified as optional in the proto definition.

category: misc
ticket: none

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (db040d5) 53.56% compared to head (f4b297b) 53.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2344      +/-   ##
==========================================
+ Coverage   53.56%   53.67%   +0.10%     
==========================================
  Files         191      192       +1     
  Lines       25730    25775      +45     
==========================================
+ Hits        13783    13834      +51     
+ Misses      10238    10233       -5     
+ Partials     1709     1708       -1     
Impacted Files Coverage Δ
app/protonil/protonil.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 21, 2023
@obol-bulldozer obol-bulldozer bot merged commit 2fb2481 into main Jun 21, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/protonil branch June 21, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants