p2p: check protonil for all receives #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
==========================================
+ Coverage 53.62% 53.66% +0.03%
==========================================
Files 192 192
Lines 25775 25818 +43
==========================================
+ Hits 13823 13855 +32
- Misses 10242 10256 +14
+ Partials 1710 1707 -3
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Jun 22, 2023
corverroos
added
the
merge when ready
xenowits
pushed a commit
that referenced
this pull request
Jun 26, 2023
Check all libp2p protos received over the wire for nil fields. Also extend `protonil` to detect nil list eleements and nil map values. category: misc ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all libp2p protos received over the wire for nil fields.
Also extend
protonilto detect nil list eleements and nil map values.category: misc
ticket: none