*: disable intrange linter #3282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go v1.23 allows to range over int slices without calling `len` first. Since it's a low-importance change, we can disable intrange linter to avoid being blocked by it during pre-commit.
|
|
I think I have updated all the places where this happens, so linter doesn't complain on any of the old code? |
|
Weird, I have it complaining on my (unrelated) PR, complaining about validatorapi 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
==========================================
+ Coverage 57.63% 57.66% +0.02%
==========================================
Files 211 211
Lines 30418 30420 +2
==========================================
+ Hits 17532 17541 +9
+ Misses 10997 10991 -6
+ Partials 1889 1888 -1 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
Sep 13, 2024
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Sep 18, 2024
Go v1.23 allows to range over int slices without calling `len` first. Since it's a low-importance change, we can disable intrange linter to avoid being blocked by it during pre-commit. category: misc ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go v1.23 allows to range over int slices without calling
lenfirst.Since it's a low-importance change, we can disable intrange linter to avoid being blocked by it during pre-commit.
category: misc
ticket: none