Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Trying to build 2.6.1 fails on Bundling #808

Closed
ericthompson opened this issue Sep 25, 2016 · 9 comments
Closed

Trying to build 2.6.1 fails on Bundling #808

ericthompson opened this issue Sep 25, 2016 · 9 comments
Assignees

Comments

@ericthompson
Copy link
Contributor

Cloned down the project and jumped to the 2.6.1 release branch, and tried NPM installing and gulp/gulp watch but get this error:
image

This keeps you from being able to load and use the localhost docs 😢

@Jahnp
Copy link
Collaborator

Jahnp commented Sep 25, 2016

I'll take a look at this.

@Jahnp
Copy link
Collaborator

Jahnp commented Oct 3, 2016

I can't repro this from a fresh clone of 2.6.1 using Node 4.2.6 and npm 3.10.7. @ericthompson, did this error crop up on a fresh clone? What versions of Node/npm are you running?

@ericthompson
Copy link
Contributor Author

ericthompson commented Oct 4, 2016

Hmm - just did a fresh clone myself, npm i, and I'm still seeing the failure.

I ended up running Node v6.2.2 and npm 3.10.7 when I tried at first. I downgraded to the latest stable version of Node, v4.6.0, did a fresh clone, a jump to the new branch (without building with the old dependencies), npm i, and then gulp watch and it worked!

Let me leave this issue open while update the V2 documentation to reflect this process.

@ericthompson ericthompson assigned ericthompson and unassigned Jahnp Oct 4, 2016
@Jahnp
Copy link
Collaborator

Jahnp commented Oct 4, 2016

So wait--did the error still occur after downgrading to Node 4.6.0? Was this on a Mac or Windows? Chances are you won't be the only one to hit this issue--I'd like to repro so it can be fixed. It could be a configuration or syntax issue.

Or did downgrading solve the problem?

@ericthompson
Copy link
Contributor Author

Sorry about the confusion - updated my comment. It did end up working once I downgraded, so I just submitted a PR to update the V2 docs to explain the need for this version of Node.

@Jahnp
Copy link
Collaborator

Jahnp commented Oct 4, 2016

Gotcha. In that case, I'd rather take a crack at a patch rather than forcing users to snap to an older version of Node :) Let's update the docs in the short term, but I'll try to get a fix out today or tomorrow if possible.

@ericthompson
Copy link
Contributor Author

Sounds good. Really looks like we should update some of these docs to explain how to view the localhost docs in a more primary way as this is the only way to see the live samples. I agree with you - let's get the updated docs in now to unblock folks now, and then get a patch in soon. Thanks for your help!

@Jahnp
Copy link
Collaborator

Jahnp commented Oct 4, 2016

Totally agreed on both fronts. I'll try to get that patch out soon.

mikewheaton pushed a commit that referenced this issue Oct 4, 2016
@ericthompson
Copy link
Contributor Author

Fixed by this release - 2.6.2. I'll go in and revert my statement in the md file and we can call this closed 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants